Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blais5 4436 #382

Merged
merged 3 commits into from
Oct 22, 2024
Merged

Blais5 4436 #382

merged 3 commits into from
Oct 22, 2024

Conversation

lambeb
Copy link
Contributor

@lambeb lambeb commented Oct 22, 2024

No description provided.

…he server using getRoleList API Call

Fixed tests to not use enumeration any longer

Updated snapshot
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.63%. Comparing base (9aed513) to head (68be7be).
Report is 15 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #382   +/-   ##
=======================================
  Coverage   60.63%   60.63%           
=======================================
  Files          36       36           
  Lines         818      818           
  Branches      185      185           
=======================================
  Hits          496      496           
  Misses        322      322           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kristian4res kristian4res left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and within a sandbox
LGTM! Nice one Ben! 👍

@kristian4res kristian4res merged commit 8e94f82 into main Oct 22, 2024
6 checks passed
@kristian4res kristian4res deleted the BLAIS5-4436 branch October 22, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants